fix if notification throw exception, the heartbeat is not stored in t…

…o the db.
louislam · Jul 22, 2021 · 03b3bb5 · 03b3bb5
1 parent 7e4a1ad
commit 03b3bb5
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/server/model/monitor.js b/server/model/monitor.js
@@ -121,8 +121,6 @@ class Monitor extends BeanModel {
                         this.id
                     ])
 
-                    let promiseList = [];
-
                     let text;
                     if (bean.status === 1) {
                         text = "✅ Up"
@@ -133,10 +131,12 @@ class Monitor extends BeanModel {
                     let msg = `[${this.name}] [${text}] ${bean.msg}`;
 
                     for(let notification of notificationList) {
-                        promiseList.push(Notification.send(JSON.parse(notification.config), msg, await this.toJSON(), bean.toJSON()));
+                        try {
+                            await Notification.send(JSON.parse(notification.config), msg, await this.toJSON(), bean.toJSON())
+                        } catch (e) {
+                            console.error("Cannot send notification to " + notification.name)
+                        }
                     }
-
-                    await Promise.all(promiseList);
                 }
 
             } else {