Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Streaming Server/Client CloseChannel method #48

Merged
merged 2 commits into from
Sep 8, 2024

Conversation

ShivanshVij
Copy link
Member

This PR modifies the generated streaming servers and clients to contain a CloseChannel method that returns a channel that will notify when the underlying connection is closed - whether it's on purpose or due to an error.

…in a `CloseChannel` method that returns a channel that will notify when the underlying connection is closed - whether it's on purpose or due to an error.
…in a `CloseChannel` method that returns a channel that will notify when the underlying connection is closed - whether it's on purpose or due to an error.
Copy link
Contributor

@SuperManifolds SuperManifolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShivanshVij ShivanshVij merged commit 2192a04 into main Sep 8, 2024
4 checks passed
@ShivanshVij ShivanshVij deleted the shiv/close-channel branch September 8, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants