Merge pull request #111 from loopholelabs/staging

Release v0.4.6
loopholelabs · Apr 28, 2022 · fa0a4e3 · fa0a4e3
2 parents 452d626 + 665f1af
commit fa0a4e3
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 4 deletions.
diff --git a/.trunk/trunk.yaml b/.trunk/trunk.yaml
@@ -1,6 +1,6 @@
 version: 0.1
 cli:
-  version: 0.10.1-beta
+  version: 0.11.0-beta
 lint:
   enabled:
     - [email protected]

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -7,6 +7,16 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
 
+## [v0.4.6] - 2022-04-28 (Beta)
+
+## Fixes
+
+- Fixing issue where generated `decode` functions for slices would not allocate the proper memory before decoding the slice values (Issue #108)
+
+## Changes
+
+- Updating Trunk Linter to `v0.11.0-beta`
+
 ## [v0.4.5] - 2022-04-22 (Beta)
 
 ## Fixes
@@ -247,7 +257,8 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 Initial Release of Frisbee
 
-[unreleased]: https://github.com/loopholelabs/frisbee/compare/v0.4.5...HEAD
+[unreleased]: https://github.com/loopholelabs/frisbee/compare/v0.4.6...HEAD
+[v0.4.6]: https://github.com/loopholelabs/frisbee/compare/v0.4.5...v0.4.6
 [v0.4.5]: https://github.com/loopholelabs/frisbee/compare/v0.4.4...v0.4.5
 [v0.4.4]: https://github.com/loopholelabs/frisbee/compare/v0.4.3...v0.4.4
 [v0.4.3]: https://github.com/loopholelabs/frisbee/compare/v0.4.2...v0.4.3

diff --git a/protoc-gen-frisbee/dockerfile b/protoc-gen-frisbee/dockerfile
@@ -2,7 +2,7 @@ FROM golang as builder
 
 ENV GOOS=linux GOARCH=amd64 CGO_ENABLED=0
 
-RUN go install github.com/loopholelabs/frisbee/[email protected].5
+RUN go install github.com/loopholelabs/frisbee/[email protected].6
 
 # Note, the Docker images must be built for amd64. If the host machine architecture is not amd64
 # you need to cross-compile the binary and move it into /go/bin.
@@ -12,7 +12,7 @@ FROM scratch
 
 # Runtime dependencies
 LABEL "build.buf.plugins.runtime_library_versions.0.name"="github.com/loopholelabs/frisbee"
-LABEL "build.buf.plugins.runtime_library_versions.0.version"="v0.4.5"
+LABEL "build.buf.plugins.runtime_library_versions.0.version"="v0.4.6"
 
 COPY --from=builder /go/bin /
 

diff --git a/protoc-gen-frisbee/examples/simple/simple.proto b/protoc-gen-frisbee/examples/simple/simple.proto
@@ -19,4 +19,9 @@ message Request {
 
 message Response{
   string Message = 1;
+}
+
+message SliceResponse {
+  repeated Response ResponseSlice = 1;
+  map<string, Response> ResponseMap = 2;
 }
diff --git a/protoc-gen-frisbee/templates/decode.templ b/protoc-gen-frisbee/templates/decode.templ
@@ -53,6 +53,9 @@ func (x *{{CamelCase .FullName}}) decode(d *packet.Decoder) error {
         for i := uint32(0); i < sliceSize; i++ {
             {{ $decoder := GetLUTDecoder $field.Kind -}}
             {{ if eq $field.Kind 11 -}} {{/* protoreflect.MessageKind */ -}}
+            if x.{{ CamelCaseName $field.Name }}[i] == nil {
+                x.{{ CamelCaseName $field.Name }}[i] = New{{ CamelCase $field.Message.FullName }}()
+            }
             err = x.{{ CamelCaseName $field.Name }}[i].decode(d)
             {{ else -}}
             x.{{ CamelCaseName $field.Name }}[i], err = d{{ $decoder }}()