Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move application recipes to how-to guides #6693

Conversation

mrmodise
Copy link
Contributor

@mrmodise mrmodise commented Oct 30, 2020

Closes #6106

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@mrmodise mrmodise force-pushed the move-application-recipes-to-how2guides branch 3 times, most recently from bad05ae to 81b0fe9 Compare November 5, 2020 13:16
@mrmodise mrmodise force-pushed the move-application-recipes-to-how2guides branch from 81b0fe9 to 31bec51 Compare November 15, 2020 06:41
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrmodise, thanks for the PR. Since this PR is in draft mode, I'm not sure if it's ready for review. I've put some comments on formatting-related items. Thanks.

@mrmodise
Copy link
Contributor Author

Thanks @dhmlau for the comments. It will be ready this week. I faced issues pulling the latest master that caused some delays on completing this

@mrmodise mrmodise force-pushed the move-application-recipes-to-how2guides branch from 31bec51 to 020c4fa Compare November 21, 2020 15:05
@mrmodise mrmodise marked this pull request as ready for review November 21, 2020 15:49
@mrmodise mrmodise force-pushed the move-application-recipes-to-how2guides branch from 020c4fa to cc56abe Compare November 21, 2020 15:49
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've reviewed mostly from the readers' point of view, and just had a minor comment. Please make sure you get other technical reviews before landing. Thanks @mrmodise!

@mrmodise mrmodise force-pushed the move-application-recipes-to-how2guides branch 2 times, most recently from 979a6dd to 429e4bb Compare November 24, 2020 03:40
@mrmodise
Copy link
Contributor Author

@dhmlau agreed, I will wait for both @bajtos and @raymondfeng to review. Particularly, around the use of the Booter class. Amazing how there is so much hidden information in LoopBack website 😄. I have purposed to surface it

@mrmodise
Copy link
Contributor Author

@bajtos please review. Thanks

@mrmodise mrmodise force-pushed the move-application-recipes-to-how2guides branch from 429e4bb to 9ec06d8 Compare January 7, 2021 20:00
@raymondfeng raymondfeng merged commit fa2dc56 into loopbackio:master Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: move Application recipes to how-to guides
3 participants