Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ensure ID is primary key after autoupdate #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: ensure ID is primary key after autoupdate #460

wants to merge 1 commit into from

Conversation

stefanblaginov
Copy link

@stefanblaginov stefanblaginov commented Jan 24, 2022 •
edited
Loading

Signed-off-by: Stefan Blaginov [email protected]

Fixes #461

Ensures that a field set as an id in the model file, gets reflected as a primary key in the MySQL database during an autoupdate.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@stefanblaginov stefanblaginov force-pushed the fix-ensure-id-is-primary-key-after-autoupdate branch from 3298cd4 to 9ff5bd1 Compare January 24, 2022 22:42
@stefanblaginov stefanblaginov marked this pull request as ready for review January 25, 2022 19:02
@achrinza achrinza self-requested a review February 9, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarpanB samarpanB samarpanB approved these changes

@achrinza achrinza achrinza approved these changes

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

@marioestradarosa marioestradarosa Awaiting requested review from marioestradarosa marioestradarosa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model's ID not set as private key in MySQL database
3 participants
@stefanblaginov @samarpanB @achrinza