Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Live Activity customization to version in Loop PR 2191, commit 03d5489 #45

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

marionbarker
Copy link
Contributor

Pull in the latest updates from [DRAFT] feature: Live Activity

@marionbarker
Copy link
Contributor Author

Summary:

Both tests were successful.

Test Plan

Test 1: apply main branch version of live_activity customization to main branch of LoopWorkspace and then update with la_update branch version

Test 2: apply customization to main branch (after clearing the customization)

Test 1:

start in LoopWorkspace folder with clean version of main branch and add main branch live_activity to the code:

/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/loopandlearn/lnl-scripts/main/CustomizationSelect.sh)"  \
   live_activity

Then make sure update works:

export PATCH_BRANCH=la_update
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/loopandlearn/lnl-scripts/main/CustomizationSelect.sh)" 
unset PATCH_BRANCH

choose to update live_activity
make sure it builds and live activity displays on lock screen.

(unset the PATCH_BRANCH each time so tests can be run independently)

Test 2:

start in LoopWorkspace folder with clean version of main branch and la_update branch of live_activity to the code:

export PATCH_BRANCH=la_update
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/loopandlearn/lnl-scripts/main/CustomizationSelect.sh)"  \
   live_activity
unset PATCH_BRANCH

make sure it builds and live activity displays on lock screen.

@marionbarker marionbarker changed the title update la patch to 03d5489 update Live Activity customization to version in Loop PR 2191, commit 03d5489 Sep 15, 2024
Copy link
Contributor

@bjorkert bjorkert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@marionbarker marionbarker merged commit 5ad1718 into dev Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants