Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement eth_estimateGas endpoints #1523

Merged
merged 30 commits into from
Jun 8, 2021
Merged

Implement eth_estimateGas endpoints #1523

merged 30 commits into from
Jun 8, 2021

Conversation

atchapcyp
Copy link
Contributor

ref: #1483

  • I added unit tests for any code that added
  • I updated the CHANGELOG.md
  • All IP is original and not copied from another source
  • I assign all copyright to Loom Network for the code in the pull request

enlight
enlight requested changes Oct 4, 2019
View reviewed changes
@atchapcyp atchapcyp mentioned this pull request Oct 4, 2019
Merged
4 tasks
@eduardonunesp
Copy link
Contributor

eduardonunesp commented Oct 7, 2019 •
edited
Loading

I have tested this branch together with eth_sendRawTransaction and the estimated gas makes sense, I'll put a test for it LoomProvider2

enlight
enlight reviewed Oct 17, 2019
View reviewed changes
enlight
enlight requested changes Oct 31, 2019
View reviewed changes
@atchapcyp
Copy link
Contributor Author

rebuild sesame

enlight
enlight requested changes Nov 12, 2019
View reviewed changes
@atchapcyp
Copy link
Contributor Author

rebuild sesame

enlight added 7 commits June 1, 2021 17:44
@enlight
Revert changes to yarn.lock
8fa80f8
@enlight
Merge branch 'master' into eth-estimate-gas
a465f2c 
# Conflicts:
#	e2e/tests/truffle/test/EthFunctions.js
#	e2e/tests/truffle/yarn.lock
@enlight
Revert auto-formatting
4fc855c
@enlight
Remove ethlint
ae43055 
ethlint is no longer maintained, can integrate solhint later instead.
@enlight
Revert yarn.lock changes (again)
85c7b1d
@enlight
Support gas parameter when calling eth_estimateGas
0b3f68b 
eth_estimateGas accepts a `gas` parameter that can be used to limit the
maximum amount of gas that can be used during estimation. Note that the
gas limit that's provided is capped at the per-tx gas limit set via the
on-chain config.

Also fixed some overly lax validation of from/to address parameters,
while it's acceptable to omit them in some scenarios it's not acceptable
to ignore invalid address values.
@enlight
Revert some earlier changes that don't need to be in this PR
bceccb1
enlight
enlight approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@enlight enlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enlight enlight merged commit 350994c into master Jun 8, 2021
@enlight enlight deleted the eth-estimate-gas branch June 8, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enlight enlight enlight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atchapcyp @eduardonunesp @enlight