[WIP] Add transaction to update init JSON #137
Conversation
|
@sidmutha Nice! Do we have a way to remove data at with a given version using cli? |
| Image: "PathToImage", | ||
| UserId: "AccountUser", | ||
| Image: "PathToImage", | ||
| Version: "v1", |
There was a problem hiding this comment.
not sure it makes sense to version the users, specifically unless there is a clear reason to
| @@ -259,8 +465,9 @@ func TestCardCollectionOperations(t *testing.T) { | |||
|
|
|||
| setup(c, pubKeyHexString, &addr, &ctx, t) | |||
| setupAccount(c, ctx, &zb.UpsertAccountRequest{ | |||
| UserId: "CardUser", | |||
| Image: "PathToImage", | |||
| UserId: "CardUser", | |||
There was a problem hiding this comment.
not sure it makes sense to version the users, specifically unless there is a clear reason to
| @@ -279,8 +486,9 @@ func TestDeckOperations(t *testing.T) { | |||
|
|
|||
| setup(c, pubKeyHexString, &addr, &ctx, t) | |||
| setupAccount(c, ctx, &zb.UpsertAccountRequest{ | |||
| UserId: "DeckUser", | |||
| Image: "PathToImage", | |||
| UserId: "DeckUser", | |||
There was a problem hiding this comment.
not sure it makes sense to version the users, specifically unless there is a clear reason to
| @@ -10,8 +10,9 @@ import ( | |||
| ) | |||
|
|
|||
| var createAccCmdArgs struct { | |||
| userID string | |||
| value string | |||
| userID string | |||
There was a problem hiding this comment.
lets just leave all the account creation alone, I'm not certain if this makes much sense yet
| @@ -1,5 +1,5 @@ | |||
| [[TestCases]] | |||
| RunCmd = "zb-cli create_account -k {{index $.AccountPrivKeyPathList 0}} -u loom" | |||
| RunCmd = "zb-cli create_account -k {{index $.AccountPrivKeyPathList 0}} -u loom -v v1" | |||
There was a problem hiding this comment.
can remove this version
|
@mattkanwisher the create account had to be modified to take in the version because the CreateAccount transaction uses the default card lists to initialise the user data. These default lists have been versioned, hence everything that uses them needs to know the version. |
|
@sidmutha there probably needs to be a 'default' version. The person creating the account shouldn't have to be aware of what the deck version is. Or a way to request what the default version is, seems odd. We can do that later, this PR looks overall fine now. Anything left to do before merging? |
|
Yeah we can have a default version in case no version is specified. We can talk to the game team and decide what that should be. |
|
e2e is fixed, I fixed the build |
[WIP] Add transaction to update init JSON
issue: #126