Upgrade to WalletConnect v2 and Coinbase Wallet SDK #1476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
enlight
commented
Jul 3, 2023
enlight
commented
- Upgrade from WalletConnect v1 to v2
- Upgrade from WalletLink to Coinbase Wallet SDK
- Upgrade from Web3 1.2.1 to 1.8.2
- Upgrade from ethers v4 to v5
- Upgrade from Webpack v4 to v5
- Fix mapping of new accounts
There was some sort of initialization error in this component, removing it now since it's not used anyway.
Account mapping modal stopped showing up after `auth.loom.games` went offline.
Istanbul.js has been abandoned and hasn't had a release in over 2 years.
The contract types were wrong and all the errors pointing this out were silenced.
`yarn test` works (with some warnings) when run directly, but `mochapack` seems to return a non-zero exit code when launched from the hook, which blocks `git push`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.