Update styles #72
Merged
Update styles #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for silver-kataifi-036a35 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Previously the entire material icons font face was being imported in the `@lookupdaily/styles` library, which was unnecessary as it was no longer being used in any of the styles. Now directly importing via a stylesheet link, and only importing the icon(s) being used in the site. This improves the performance rating in Lighthouse - as it removes a blocking resource.
As I have updated the site with system fonts which will look slightly different on each browser/operating system, replacing the use of text in the 'logo' with the svg used in the avatar, so this is more consistent.
lookupdaily
force-pushed
the
update-styles
branch
from
641deb3 to
147778f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lookupdaily/stylesto v2.0.6