Update jspsych config #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fd3fad6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
okaycj
force-pushed
the
update-jspsych-config
branch
3 times, most recently
from
c3dc5bb to
2375c05
Compare
okaycj
force-pushed
the
update-jspsych-config
branch
from
08e7d90 to
214d575
Compare
becky-gilbert
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Wow, this looks like it was hard to figure out. Lots of breaking changes in package updates.
I reviewed all the changes (but I'm not a rollup expert so not sure how helpful my review is there). I also pulled this down locally to make sure I could install, build and run. Everything works - thank you!
|
Oh! This does need a changeset before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates all packages. There's a large change with the
@lookit/datapackage. It (specifically@aws-sdk/s3-client) doesn't work well with Rollup. I was unable to get it to build with jsPsych's config, so put together a custom config.