add safe guard for headers["X-Frame-Options"].upcase #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lookbook-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Spone
approved these changes
Nov 29, 2023
|
Thanks @adrienpoly for the fix! |
|
It would be great to release this fix to RubyGems 😇 |
|
@matiasleidemer Thanks for the reminder! I had completely forgotten I hadn't published a new release with this in 🙄 I've just pushed up v2.2.1 that includes this fix. Sorry for any inconvenience :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since upgrading to 2.20 I had an error coming from the preview controller
see for details #549 (comment)