Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support bulk backup backing images (backport #836) #837

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 23, 2024

What this PR does / why we need it

  • Allow to bulk backup backing images to different backup target

Issue

[UI][FEATURE] Multiple backup stores support #8647

Test Result

  • Go to the Backing Image page
  • Select multiple backing images and click the bulk action Backup
  • When the modal pop up, select a target and click Backup
    Screenshot 2024-12-23 at 4 25 37 PM (2)
  • The backups should be created successfully.

Additional documentation or context

Test with LONGHORN_MANAGER_IP=http://134.209.101.112:30001/ npm run dev

Summary by CodeRabbit

  • New Features

    • Introduced a backup modal with enhanced user interaction for bulk actions.
    • Added support for selecting backup targets in the backup process.
  • Bug Fixes

    • Improved state management and organization of action handling within the bulk actions component.
  • Style

    • Updated styles for bulk action buttons and the backup modal for better responsiveness and visual clarity.
  • Documentation

    • Enhanced PropTypes validation to ensure required props are passed to components.

This is an automatic backport of pull request #836 done by [Mergify](https://mergify.com).

Signed-off-by: Yi-Ya Chen <[email protected]>
(cherry picked from commit 21c4758)
@mergify mergify bot mentioned this pull request Dec 23, 2024
1 task
Copy link

coderabbitai bot commented Dec 23, 2024

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@houhoucoop houhoucoop merged commit 38510f0 into v1.8.x Dec 23, 2024
5 checks passed
@houhoucoop houhoucoop deleted the mergify/bp/v1.8.x/pr-836 branch December 23, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant