-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: aggregate "*-dev-*" versions into single "dev" version #3177
Merged
innobead
merged 1 commit into
longhorn:master
from
PhanLe1010:upgrade-check-exclude-dev-versions
Sep 25, 2024
Merged
fix: aggregate "*-dev-*" versions into single "dev" version #3177
innobead
merged 1 commit into
longhorn:master
from
PhanLe1010:upgrade-check-exclude-dev-versions
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhanLe1010
force-pushed
the
upgrade-check-exclude-dev-versions
branch
from
September 25, 2024 02:11
43b6c9e
to
a9d117f
Compare
derekbit
previously approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This will prevent the upgrade responder from having too many tags which can be a performance issue longhorn-9522 Signed-off-by: Phan Le <[email protected]>
PhanLe1010
force-pushed
the
upgrade-check-exclude-dev-versions
branch
from
September 25, 2024 02:29
a9d117f
to
df07db8
Compare
PhanLe1010
changed the title
fix: do not send upgrade check requests if the current version is a dev version
fix: aggregate "*-dev-*" versions into single "dev" version
Sep 25, 2024
derekbit
approved these changes
Sep 25, 2024
@mergify backport v1.7.x, v1.6.x, v1.5.x |
❌ No backport have been created
GitHub error:
GitHub error:
|
innobead
approved these changes
Sep 25, 2024
@mergify backport v1.7.x v1.6.x |
✅ Backports have been created
|
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will prevent the upgrade responder from having too many tags which can be a performance issue
longhorn/longhorn#9522