fix(crd): update conversion webhook port to 9501 #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekbit
force-pushed
the
issue-9438
branch
from
4aba24f
to
5ef03a0
Compare
PhanLe1010
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
LGTM
Just want to double check that we don't have an issue even though the port here is wrong because the lCRDs in the onghorn/longhorn repo still have correct port. Most of the time, we use the yaml in longhorn/longhorn instead. But this fix is good to make them consistent. Am I missing anything?
You're right. This is only for consistency, we've updated longhorn/longhorn chart and manifest before. |
longhorn/longhorn crds.yaml is already updated. Correct the port number to avoid any confusion. Longhorn 9438 Signed-off-by: Derek Su <[email protected]>
derekbit
force-pushed
the
issue-9438
branch
from
5ef03a0
to
6390575
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Issue longhorn/longhorn#9438
What this PR does / why we need it:
longhorn/longhorn crds.yaml is already updated.
Correct the port number to avoid any confusion.
Special notes for your reviewer:
Additional documentation or context