-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(encrypt): close encrypted volume if it is opened #3140
fix(encrypt): close encrypted volume if it is opened #3140
Conversation
2c50b01
to
b60a8a6
Compare
b60a8a6
to
f8206c6
Compare
f8206c6
to
c6c1511
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
c6c1511
to
e11e152
Compare
8d9a273
to
acade6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, LGTM
- Update the error messages
- QA test cases need to include
- encrypted volume attachment and detachment
- validate the case when path is
(null)
In normal process of attaching a volume via CSI, the encrypted volume should be in closed or inactivated state before Longhorn attempts to open it. ref: longhorn/longhorn 9385 Signed-off-by: James Lu <[email protected]>
acade6b
to
6a55644
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mergifyio backport v1.7.x v1.6.x |
✅ Backports have been created
|
Which issue(s) this PR fixes:
Issue # longhorn/longhorn#9385
What this PR does / why we need it:
In the normal process of attaching a volume via CSI, the encrypted volume should be closed or inactivated before Longhorn attempts to open it.
Special notes for your reviewer:
Additional documentation or context
Full regression test:
https://ci.longhorn.io/job/private/job/longhorn-tests-regression/7529https://ci.longhorn.io/job/private/job/longhorn-tests-regression/7538/