Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2 volume/configurable cpu mask): support configurable CPU cores #3111

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

derekbit
Copy link
Member

Which issue(s) this PR fixes:

Issue longhorn/longhorn#8835

What this PR does / why we need it:

Special notes for your reviewer:

Additional documentation or context

@derekbit derekbit self-assigned this Aug 27, 2024
@derekbit derekbit force-pushed the v2-configurable-cpu-cores branch 3 times, most recently from 1e2e801 to 86c83e0 Compare August 27, 2024 16:11
@innobead
Copy link
Member

innobead commented Aug 27, 2024

Will this be part of dynamic scheduler?

@derekbit
Copy link
Member Author

Will this be part of dynamic scheduler?

No. This is only for the configurable dedicated cpu cores.

datastore/longhorn.go Outdated Show resolved Hide resolved
types/setting.go Show resolved Hide resolved
@derekbit derekbit force-pushed the v2-configurable-cpu-cores branch 2 times, most recently from aa9fdd8 to 947b231 Compare August 29, 2024 05:12
@derekbit derekbit marked this pull request as ready for review August 29, 2024 05:12
controller/instance_manager_controller.go Outdated Show resolved Hide resolved
types/setting.go Outdated Show resolved Hide resolved
DamiaSan
DamiaSan previously approved these changes Aug 29, 2024
@derekbit
Copy link
Member Author

@shuo-wu Could you review it before merging it if you have time? Thank you.

@derekbit
Copy link
Member Author

cc @c3y1huang

innobead
innobead previously approved these changes Aug 31, 2024
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

datastore/longhorn.go Outdated Show resolved Hide resolved
types/setting.go Show resolved Hide resolved
innobead
innobead previously approved these changes Sep 2, 2024
Copy link
Member

@innobead innobead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merge this until the description of the setting is updated after the longhorn/longhorn PR is merged.

… instanceManager CRD

- Add Spec.DataEngineSpec.V2.CPUMask
- Add Status.DataEngineStatus.V2.CPUMask

Longhorn 8835

Signed-off-by: Derek Su <[email protected]>
@innobead innobead merged commit 8a98944 into longhorn:master Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants