Improve replica revision counter #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejweber
reviewed
May 6, 2024
This replica HTTP service was used when the replica gRPC service had not been introduced. Now we neither rely on it for the engine-replica communication, nor use it for debugging. There is no need to retain these code. Signed-off-by: Shuo Wu <[email protected]>
Longhorn 8436 Signed-off-by: Shuo Wu <[email protected]>
Longhorn 8436 Signed-off-by: Shuo Wu <[email protected]>
Longhorn 8436 Signed-off-by: Shuo Wu <[email protected]>
ejweber
approved these changes
May 10, 2024
PhanLe1010
approved these changes
May 31, 2024
No, we don't need it anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
longhorn/longhorn#8436
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context
This PR implements idea 4 and 5 mentioned in this comment