Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gha): add reusable workflow "CodeQL" #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+45 −0
Open

feat(gha): add reusable workflow "CodeQL" #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 45 additions & 0 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: "CodeQL"

on:
workflow_call:
secrets:
CUSTOM_GITHUB_TOKEN:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if we need this for the workflow? We could add extra permissions in the job permission instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need it for the security-events: write. CUSTOM_GITHUB_TOKEN is passed from the caller workflow and will use default GITHUB_TOKEN.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you already customized that permission at https://github.com/longhorn/gh-configs/pull/2/files#diff-12783128521e452af0cfac94b99b8d250413c516ec71fe6d97dbea666ff7ba27R29. Do we still need the caller to provide a customized github token?

description: |
Github token with write access to the repo
required: true
workflow_dispatch:
push:
branches:
- master
- main
- v*
pull_request:
types: [opened, synchronize]
branches:
- master
- main
- v*

jobs:
codeql:
name: CodeQL security scanning
runs-on: ubuntu-latest
permissions:
# required for all workflows
security-events: write

# required to fetch internal or private CodeQL packs
# packages: read

# only required for workflows in private repositories
# actions: read
# contents: read
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Initialize CodeQL
uses: github/codeql-action/init@v3
with:
languages: go
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3