fix(preflight): check package install by status flag

Signed-off-by: Raphanus Lo <[email protected]>

pkg/local/preflight/packagemanager/apt.go

@@ -1,12 +1,32 @@
 package packagemanager
 
 import (
+	"strings"
 	"time"
 
 	commonns "github.com/longhorn/go-common-libs/ns"
 	commontypes "github.com/longhorn/go-common-libs/types"
 )
 
+const (
+	// Ref: man 1 dpkg-query
+
+	dpkgDesiredActionUnknown = "u"
+	dpkgDesiredActionInstall = "i"
+	dpkgDesiredActionHold    = "h"
+	dpkgDesiredActionRemove  = "r"
+	dpkgDesiredActionPurge   = "p"
+
+	dpkgStatusNotInstalled     = "n"
+	dpkgStatusConfigFiles      = "c"
+	dpkgStatusHalfInstalled    = "H"
+	dpkgStatusUnpackaged       = "U"
+	dpkgStatusHalfConfigured   = "F"
+	dpkgStatusTriggersAwaiting = "W"
+	dpkgStatusTriggersPending  = "t"
+	dpkgStatusInstalled        = "i"
+)
+
 type AptPackageManager struct {
 	executor *commonns.Executor
 }
@@ -64,6 +84,19 @@ func (c *AptPackageManager) GetServiceStatus(name string) (string, error) {
 }
 
 // CheckPackageInstalled checks if a package is installed
-func (c *AptPackageManager) CheckPackageInstalled(name string) (string, error) {
-	return c.executor.Execute([]string{}, "dpkg-query", []string{"-l", name}, commontypes.ExecuteNoTimeout)
+func (c *AptPackageManager) CheckPackageInstalled(name string) (output string, err error) {
+	// example for an installed package:
+	// $ dpkg-query -f='${binary:Package} ${db:Status-Abbrev}' -W nfs-common
+	// nfs-common ii
+	output, err = c.executor.Execute([]string{}, "dpkg-query", []string{"-f=${binary:Package} ${db:Status-Abbrev}", "-W", name}, commontypes.ExecuteNoTimeout)
+	if err != nil {
+		return
+	}
+	fields := strings.Fields(strings.TrimSpace(output))
+	if len(fields) == 2 {
+		if fields[0] == name && fields[1] == dpkgDesiredActionInstall+dpkgStatusInstalled {
+			return output, nil
+		}
+	}
+	return output, packageNotInstalledError
 }

pkg/local/preflight/packagemanager/packagemanager.go

@@ -1,6 +1,7 @@
 package packagemanager
 
 import (
+	"errors"
 	"fmt"
 	"time"
 
@@ -19,6 +20,8 @@ const (
 	// PackageManagerQlist            = PackageManagerType("qlist")
 )
 
+var packageNotInstalledError = errors.New("package not installed")
+
 type PackageManager interface {
 	UpdatePackageList() (string, error)
 	InstallPackage(name string) (string, error)