Add download button #630
Closed
Add download button #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is based on un-merged pull request #323.
I created a download link (down arrow) next to the close link instead of using the picture overlay, to me this feels less intrusive and easier to notice. In the process I ended up fixing/enhancing div.lb-closeContainer CSS, so that two (or more) buttons (links) would be possible. That also required reviewing the close link CSS, which is now pretty much identical with the new download link CSS.
I added an option to enable or disable it: showDownloadButton: true / false. The link is hidden by default, so that the default behaviour doesn't change. The download button image was also modified to match the close button image size, eliminating possible future layout problems.
It looks like the jQuery way of adding href and download attributes to an existing a element do not get picked up by the browser, so I had to implement a custom function that actually triggers the download.