Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI command wrapper #1037

Merged
merged 7 commits into from
Jan 29, 2025
Merged

CLI command wrapper #1037

merged 7 commits into from
Jan 29, 2025

Conversation

CarlosGamero
Copy link
Contributor

@CarlosGamero CarlosGamero commented Jan 29, 2025 •
edited
Loading

Replacing CliContextUtils with CliCommandWrapper providing the following out-of-the-box improvements:

  • App start and stop
  • Request context generation
  • Args parsing and validation based on Zod + type check
  • Error handling
  • Process exit

@CarlosGamero CarlosGamero self-assigned this Jan 29, 2025
@CarlosGamero CarlosGamero marked this pull request as ready for review January 29, 2025 17:46
@CarlosGamero CarlosGamero requested a review from a team as a code owner January 29, 2025 17:46
kibertoad
kibertoad approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@kibertoad kibertoad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is really cool!

@CarlosGamero CarlosGamero merged commit 0d6ec38 into main Jan 29, 2025
3 checks passed
@CarlosGamero CarlosGamero deleted the feat/cli-command-wrapper branch January 29, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees

@CarlosGamero CarlosGamero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlosGamero @kibertoad