-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prefix suffix config of args #965
base: main
Are you sure you want to change the base?
Conversation
LittleBadBad
commented
Jul 4, 2023
- add prefix suffix config of args in hardcode
- add new react-i18next template
- remove the "," in the replacer
fixed issues in #964 |
d0426c6
to
f16be95
Compare
f16be95
to
f651e1d
Compare
I've already done the e2e test locally, but the test case would cause bunch of test code modifications, so only key modifications were submitted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LittleBadBad Thank you for the change!
Can you merge the current main branch, please?
I'm eager to include this in the upcoming release if the comma change is fully backward compatible.
…t/args-pre-suf
4b1e327
to
dee86f4
Compare
src/extraction/parseHardString.ts
Outdated
@@ -1,3 +1,4 @@ | |||
import { Config } from '~/core' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are failing with an error:
Error: Cannot find module '~/core'
Require stack:
- /Users/terales/Documents/GitHub/i18n-ally-lokalise/src/extraction/parseHardString.ts
It looks like you can't import it in this way and I'm not sure not how exactly it should be done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try and see how it look,
just call it an argsToStringCallback
please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all unit test passed, I'll push this commit
3f1e537
to
3f95c0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LittleBadBad I've tried to extract into {{t('some-key')}}
but was not able to, see the video:
2023-09-23_10-34-38.mp4
Am I missing anything?
the "args" means the args in the string, like: |
in your case, you can try put some arg in the string |
…t/args-pre-suf
66992d4
to
4bf0320
Compare
|