Support for i18n.js framework #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if forgot about something. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bumping, keeping this issue alive. |
|
@RobertSasak We have created a fork of i18n-ally. I'm happy to integrate your work into the fork. Can you send me a PR over here? |
|
This PR is also available for a fork https://github.com/openscript-ch/i18n-ally-fork/pulls |
terales
previously approved these changes
Aug 27, 2023
terales
requested changes
Aug 27, 2023
There was a problem hiding this comment.
@RobertSasak can you take a look at the e2e test failures, please?
https://github.com/lokalise/i18n-ally/actions/runs/5993184825/job/16253374651?pr=690
|
I have removed unused imports, lets see it the tests pass now. |
terales
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is inpired by next i18n and in a way works the same way.