Support Namespace Delimiters and allow vertical bar (|) by default #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikumi
force-pushed
the
feat/namespace-delimiters
branch
from
b075520
to
49c87fa
Compare
|
I myself can confirm that the zh-CN and zh-TW translations are correct; others may need review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a config option for custom Namespace Delimiters, which was hardcoded as
[".", ":", "/"]before.Additionally,
"|"is allowed by default, considering its usage by me and my collegues. However this can be further reviewed and/or removed.This PR should close #736.