Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-46689 - Change datasources API permissions to Admin Only #53

Conversation

yasmin-tr
Copy link

What is this feature?

Since grafana 8.5 the permission system changed (RBAC was enabled) and the datasources read APIs were changed to be from admin only to be available to other users. We want to maintain the access to datasources for admin only in these APIs. We will expose another API with only relevant datasource data we want available.

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

Since grafana 8.5 the permission system changed (RBAC was enabled) and the datasources read APIs were changed to be from admin only to be available to other users.
We want to maintain the access to datasources for admin only in these APIs.
We will expose another API with only relevant datasource data we want available.
@yasmin-tr
Copy link
Author

run-test

Copy link

github-actions bot commented Nov 9, 2024

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update or ping for review. Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 9, 2024
Copy link

This pull request has been automatically closed because it has not had any further activity in the last 2 weeks. Thank you for your contributions!

@github-actions github-actions bot closed this Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant