DEV-46689 - Change datasources API permissions to Admin Only #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since grafana 8.5 the permission system changed (RBAC was enabled) and the datasources read APIs were changed to be from admin only to be available to other users. We want to maintain the access to datasources for admin only in these APIs. We will expose another API with only relevant datasource data we want available.
|
run-test |
yasmin-tr
changed the title
yasmin-tr
deleted the
DEV-46158-change-datasources-api-permissions-to-admin-only
branch
yasmin-tr
restored the
DEV-46158-change-datasources-api-permissions-to-admin-only
branch
yasmin-tr
deleted the
DEV-46158-change-datasources-api-permissions-to-admin-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Since grafana 8.5 the permission system changed (RBAC was enabled) and the datasources read APIs were changed to be from admin only to be available to other users.
We want to maintain the access to datasources for admin only in these APIs. We will expose another API with only relevant datasource data we want available.
Why do we need this feature?
[Add a description of the problem the feature is trying to solve.]
Who is this feature for?
[Add information on what kind of user the feature is for.]
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: