forked from grafana/grafana
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV-46410 Do not send a notification on error or no data state #41
Merged
yasmin-tr
merged 10 commits into
v10.4.x-logzio
from
DEV-46410-Do-not-send-a-notification-on-error-or-no-data-state
Sep 22, 2024
Merged
DEV-46410 Do not send a notification on error or no data state #41
yasmin-tr
merged 10 commits into
v10.4.x-logzio
from
DEV-46410-Do-not-send-a-notification-on-error-or-no-data-state
Sep 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following changes: * Do not send a notification on error or no data state. * Change default ExecErrState to OK * Enforce OK state to validation
run-test |
run-test |
…tion-on-error-or-no-data-state' into DEV-46410-Do-not-send-a-notification-on-error-or-no-data-state
run-test |
…on-on-error-or-no-data-state
run-test |
1 similar comment
run-test |
ohadza
approved these changes
Sep 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note - we should think again on comments (of old codes), not blocking
* added tests to verify create+update response value is OK
run-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Added the following changes:
Why do we need this feature?
What currently is happening in “vanilla” 10:
Problems:
What we want: