DEV-43895: expose putAlerts API #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…84457) * I18n: Expose current UI language in Grafana config * fix
* WIP * Refactor code a bit so we can sticky the main graph and tabs * Make sure it works in Firefox. Avoid annoying warnings in breakdown tab. Update pin metrics graph label * Small copy change Co-authored-by: Darren Janeczek <[email protected]> --------- Co-authored-by: Darren Janeczek <[email protected]>
* reset edit index on variable delete * adjust delete variable test * adjust test to be more in line with user flow
stop pointerEvents on the correct element
…#84407) * getAllFields: refactor for improved performance * LogRowMessageDisplayedFields: refactor line construction for performance * AsyncIconButton: refactor to prevent infinite loops
… to list team permissions (grafana#84650) * display teams to team reader if they also have the access to list team permissions * fix a typo in the docs
Use cloudMigrationIsTarget config
) * feat: make it possible to specify prop types for component extensions * Update packages/grafana-runtime/src/services/pluginExtensions/getPluginExtensions.ts * chore: adapted test case * chore: update betterer * feat: update types for configureComponentExtension() * fix: remove type specifics for `configureExtensionComponent` * Update betterer config --------- Co-authored-by: Darren Janeczek <[email protected]> Co-authored-by: Darren Janeczek <[email protected]>
…ds (grafana#84608) * Add ScopeDashboard --------- Co-authored-by: Todd Treece <[email protected]>
* add alert to annotation result * cleanup * add tests * more refactoring * apply pr feedback * change severity * use toHaveAlert matcher
New Crowdin translations by GitHub Action Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…#84665) fix: use description of data source to shorten label
New Crowdin translations by GitHub Action Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* fix: use cascader's clear button * fix: remove the prefix filter from metric select * fix: remove supporting code in metric select scene - For the removed prefix filter * fix: spacing
* Adds color and stroke-dasharray support for node graph edges Adds support for providing color, highlighted color, and visual display of node graph edges as dashed lines via stroke-dasharray. * Updates node graph documentation * Updates documentation Adds default for `highlightedColor` * Update docs/sources/panels-visualizations/visualizations/node-graph/index.md Co-authored-by: Fabrizio <[email protected]> * Update packages/grafana-data/src/utils/nodeGraph.ts Co-authored-by: Fabrizio <[email protected]> * Update docs/sources/panels-visualizations/visualizations/node-graph/index.md Co-authored-by: Isabel Matwawana <[email protected]> * Removes highlightedColor; deprecates highlighted Per [request](grafana#83855 (comment)), deprecates `highlighted` in code and documentation, and removes `highlightedColor` as an additional property. `highlighted` will continue to be supported in its original state (makes the edge red), but is superseded if `color` is provided. * Update types.ts Missed a file in my last commit. Removes `highlightedColor` and deprecates `highlighted`. * Add test scenario in test data source --------- Co-authored-by: Fabrizio <[email protected]> Co-authored-by: Isabel Matwawana <[email protected]> Co-authored-by: Andrej Ocenas <[email protected]>
* initial start * don't use getTagKeysProvider * some cleanup * undo kinds adjustment * simplify * remove async declaration * add description and a couple of unit tests * add transformSaveModelToScene test * add tests for AdHocVariableForm * add tests for AdHocFiltersVariableEditor * update to defaultKeys * fix snapshots * update to 3.13.3
…84521) * feat: integrate dashboard panels with metrics explore - add dashboard panel menu items (in non-scenes dashboard) to open `metric{filters}` entries detected from queries to launch "metrics explorer" drawers for the selected `metric{filter}` * fix: remove OpenEmbeddedTrailEvent * fix: use modal manager dismiss capabilities instead
* Introduce new configuration for migration locking * Remove feature toggle * Fix test and turn it into an integration * Fix docs
* Canvas: Add corner radius option * Update connection radius logic * Simplify angle calcs * Simplify math to be a bit more clear and efficient * Add checks for hyperbola behavior * Prevent arc calcs if no radius * Add comments for SOME clarity * Add some more clarity to comments * Fix linter issue * Check for segment overlap for first vertex * Update public/app/plugins/panel/canvas/components/connections/ConnectionSVG.tsx * Add comment for calc clarity
…fana#77007) * allow users with regular actions access provisioning API paths * update methods that read rules skip new authorization logic if user CanReadAllRules to avoid performance impact on file-provisioning update all methods to accept identity.Requester that contains all permissions and is required by access control. * create deltas for single rul e * update modify methods skip new authorization logic if user CanWriteAllRules to avoid performance impact on file-provisioning update all methods to accept identity.Requester that contains all permissions and is required by access control. * implement RuleAccessControlService in provisioning * update file provisioning user to have all permissions to bypass authz * update provisioning API to return errutil errors correctly --------- Co-authored-by: Alexander Weaver <[email protected]>
* Added new connector functions and new shape elements * Grouped basic elements, added element intro, moved element snapping info, and added subheadings for connectors section * Copy edits and restructuring * Add rotation * Broke up sentence * Added gif using midpoint controls * ihm/180324-canvas-flowchart-features/ run linter * Remove comment * Removed extra line --------- Co-authored-by: jev forsberg <[email protected]>
… specified for a panel (grafana#84999)
…els (grafana#84781) feat: sync the yaxis of breakdown panels
* attempt at solving issue and resetting bounds to match panel content * cleanup failed experiments * add toggle for infinite pan - dont love naming but open to suggestions; clean up scene transform function * add ability to "infinite" zoom (i.e. render more canvas via zooming out) * slight refactor * revert refactor as it broke things
* Fix typo * Create handler arguments * Create handler arguments editor * Create link in editor * Add labels to arguments editor fields * Create unit tests * Hide "Additional settings" header when no additional settings possible * Remove div * Fix invalid DOM --------- Co-authored-by: jev forsberg <[email protected]>
With this change, we no longer need to persist silence/nflog states to disk in addition to the kvstore
…84809) Chore: Remove gf-form from Annotation Query Editor - Influx DB
…le (grafana#84397) * add feature toggle usePrometheusFrontendPackage * add feature toggle logic to Prometheus module * use config editor with package and remove configOverhaul feature toggle * update betterer because we will be removing other files as we replace with files from @grafana/prometheus * fix exemplar ds picker selector * add more description to ts-ignore * remove go.work.sum change * copy go.work.sum from main * update go.work.sum after talking with ismail * put back the promlib entry --------- Co-authored-by: ismail simsek <[email protected]>
yasmin-tr
reviewed
Mar 24, 2024
| @@ -56,6 +65,15 @@ func (api *API) RegisterLogzioAlertingApiEndpoints(srv *LogzioAlertingApi, m *me | |||
| m, | |||
| ), | |||
| ) | |||
| group.Post( | |||
| toMacaronPath("/internal/alert/api/v1/sendNotifications"), | |||
There was a problem hiding this comment.
i guess we're gonna need to talk about the api design (path , body etc...)
but just as first comment - api-guidelines is to use "-" between words in api paths and not cammel case, since HTTP is not case-sensitive this is not very helpful. and in general this is the standard in APIs
This reverts commit 9b25b45.
yasmin-tr
force-pushed
the
DEV-43744-alert-eval-api
branch
from
69867a8 to
46080fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Expose putAlerts API to send notifications
Why do we need this feature?
As we intend to have separate instances for alert manager and alert evaluation, managed from the outside, we need to expose put alerts API.