DEV-43657 - Add app url with additional path #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to support App url for logzio for alert notification
|
run-test |
1 similar comment
|
run-test |
|
run-test |
3 similar comments
|
run-test |
|
run-test |
|
run-test |
ohadza
approved these changes
Jun 23, 2024
Comment on lines
+252
to
+256
| //appUrl, err := url.Parse(ng.Cfg.AppURL) | ||
| //if err != nil { | ||
| // ng.Log.Error("Failed to parse application URL. Continue without it.", "error", err) | ||
| // appUrl = nil | ||
| //} |
There was a problem hiding this comment.
shouldn't we remove these comments?
There was a problem hiding this comment.
since it is the original code of grafana i thought it is good to leave instead of remove, so we know:
- what was the original version more easy
- easier merge conflicts - if there are any changes on these lines it will be easier to connect it to previous version and see what changes we might need to do accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
as part of: Set APP url to logzio grafana for alert notification URLs
Why do we need this feature?
so app url in notifications can redirect properly to the logzio app