Skip to content

signature_version support s3 not v2 #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/index.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ This plugin supports the following configuration options plus the <<plugins-{typ
| <<plugins-{type}s-{plugin}-server_side_encryption>> |<<boolean,boolean>>|No
| <<plugins-{type}s-{plugin}-server_side_encryption_algorithm>> |<<string,string>>, one of `["AES256", "aws:kms"]`|No
| <<plugins-{type}s-{plugin}-session_token>> |<<string,string>>|No
| <<plugins-{type}s-{plugin}-signature_version>> |<<string,string>>, one of `["v2", "v4"]`|No
| <<plugins-{type}s-{plugin}-signature_version>> |<<string,string>>, one of `["s3", "v4"]`|No
| <<plugins-{type}s-{plugin}-size_file>> |<<number,number>>|No
| <<plugins-{type}s-{plugin}-ssekms_key_id>> |<<string,string>>|No
| <<plugins-{type}s-{plugin}-storage_class>> |<<string,string>>, one of `["STANDARD", "REDUCED_REDUNDANCY", "STANDARD_IA", "ONEZONE_IA"]`|No
Expand Down
2 changes: 1 addition & 1 deletion lib/logstash/outputs/s3.rb
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ class LogStash::Outputs::S3 < LogStash::Outputs::Base

# The version of the S3 signature hash to use. Normally uses the internal client default, can be explicitly
# specified here
config :signature_version, :validate => ['v2', 'v4']
config :signature_version, :validate => ['s3', 'v4']

# Define tags to be appended to the file on the S3 bucket.
#
Expand Down
2 changes: 1 addition & 1 deletion spec/outputs/s3_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
context "#register configuration validation" do
describe "signature version" do
it "should set the signature version if specified" do
["v2", "v4"].each do |version|
["s3", "v4"].each do |version|
s3 = described_class.new(options.merge({ "signature_version" => version }))
expect(s3.full_options).to include(:signature_version => version)
end
Expand Down