Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for variable in message properties and message headers #80

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions examples/sample.conf
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,21 @@ input {
stdin {}
}

filter {
mutate {
add_field => {"[@metadata][eventType]" => "MessageType"}
}
}

output {
rabbitmq {
host => "127.0.0.1"
exchange => "foo"
exchange_type => "topic"
message_properties => {
"content_encoding" => "utf8"
"content_type" => "application/json"
"type" => "%{[@metadata][eventType]}"
}
}
}
9 changes: 6 additions & 3 deletions lib/logstash/outputs/rabbitmq.rb
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ def register
@thread_local_exchange = java.lang.ThreadLocal.new
end

def symbolize(myhash)
Hash[myhash.map{|(k,v)| [k.to_sym,v]}]
def symbolize(myhash, event)
Hash[myhash.map{|(k,v)| [k.to_sym, if v.is_a? String then event.sprintf(v)
elsif v.is_a? Hash then symbolize(v, event) else v end]}]
end

def multi_receive_encoded(events_and_data)
Expand All @@ -63,7 +64,9 @@ def multi_receive_encoded(events_and_data)

def publish(event, message)
raise ArgumentError, "No exchange set in HareInfo!!!" unless @hare_info.exchange
local_exchange.publish(message, :routing_key => event.sprintf(@key), :properties => symbolize(@message_properties.merge(:persistent => @persistent)))
local_exchange.publish(message, :routing_key => event.sprintf(@key), :properties => symbolize(@message_properties.merge(
:persistent => @persistent
), event))
rescue MarchHare::Exception, IOError, AlreadyClosedException, TimeoutException => e
@logger.error("Error while publishing. Will retry.",
:message => e.message,
Expand Down
30 changes: 23 additions & 7 deletions spec/outputs/rabbitmq_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,22 @@
let(:exchange) { "myexchange" }
let(:key) { "mykey" }
let(:persistent) { true }
let(:event_type) { "MessageType" }
let(:var_event_type) { "%{[@metadata][event_type]}" }
let(:event_metadata) {
{"event_type" => event_type }
}
let(:rabbitmq_settings) {
{
"host" => host,
"port" => port,
"exchange_type" => exchange_type,
"exchange" => exchange,
"key" => key,
"persistent" => persistent
"persistent" => persistent,
"message_properties" => {
"type" => var_event_type
}
}
}
let(:instance) { klass.new(rabbitmq_settings) }
Expand All @@ -39,7 +47,7 @@
end

it 'should send the correct metadata (twice)' do
expected_metadata = {:routing_key => event.sprintf(key), :properties => {:persistent => persistent }}
expected_metadata = {:routing_key => event.sprintf(key), :properties => {:persistent => persistent, :type => event_type }}
expect(exchange).to have_received(:publish).with(anything, expected_metadata).twice
end
end
Expand Down Expand Up @@ -74,14 +82,15 @@
end

describe "#publish_encoded" do
let(:event) { LogStash::Event.new("foo" => "bar") }
let(:event) { LogStash::Event.new("foo" => "bar", "@metadata" => {"event_type" => event_type }) }
let(:sprinted_key) { double("sprinted key") }
let(:encoded_event) { LogStash::Json.dump(event) }

describe "issuing the publish" do
before do
allow(exchange).to receive(:publish).with(any_args)
allow(event).to receive(:sprintf).with(key).and_return(sprinted_key)
allow(event).to receive(:sprintf).with(var_event_type).and_return(event_type)
instance.send(:publish, event, encoded_event)
end

Expand All @@ -90,7 +99,7 @@
end

it "should send the correct metadata" do
expected_metadata = {:routing_key => sprinted_key, :properties => {:persistent => persistent }}
expected_metadata = {:routing_key => sprinted_key, :properties => {:persistent => persistent, :type => event_type }}

expect(exchange).to have_received(:publish).with(anything, expected_metadata)
end
Expand Down Expand Up @@ -136,14 +145,20 @@
let(:exchange) { "myexchange" }
let(:exchange_type) { "topic" }
let(:priority) { 34 }
let(:event_type) { "MessageType" }
let(:var_event_type) { "%{[@metadata][event_type]}" }
let(:event_metadata) {
{"event_type" => event_type }
}
let(:default_plugin_config) {
{
"host" => "127.0.0.1",
"exchange" => exchange,
"exchange_type" => exchange_type,
"key" => "foo",
"message_properties" => {
"priority" => priority
"priority" => priority,
"type" => var_event_type
}
}
}
Expand All @@ -162,7 +177,7 @@ def spawn_and_wait(instance)
# Extra time to make sure the output can attach
sleep 1
end
let(:message) { LogStash::Event.new("message" => "Foo Message", "extra_field" => "Blah") }
let(:message) { LogStash::Event.new("message" => "Foo Message", "extra_field" => "Blah", "@metadata" => event_metadata) }
let(:encoded) { message.to_json }
let(:test_connection) { MarchHare.connect(instance.send(:rabbitmq_settings)) }
let(:test_channel) { test_connection.create_channel }
Expand Down Expand Up @@ -202,11 +217,12 @@ def spawn_and_wait(instance)

message, payload = test_queue.pop
expect(message.properties.to_s).to include("priority=#{priority}")
expect(message.properties.to_s).to include("type=#{event_type}")
end
end

describe "sending a message with an exchange specified" do
let(:message) { LogStash::Event.new("message" => "Foo Message", "extra_field" => "Blah") }
let(:message) { LogStash::Event.new("message" => "Foo Message", "extra_field" => "Blah", "@metadata" => event_metadata) }

before do
@received = nil
Expand Down