Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable in message properties #79

Closed

Conversation

krazar
Copy link

@krazar krazar commented Nov 29, 2018

Hello,

This merge request fixes the same issue as #72 .
I just added the possibility to have variable in headers as well.

The example has been updated.
The tests has been updated as well to take this scenario into account.

However, I am totally new to Ruby, so someone should review it before merge.

@ghost
Copy link

ghost commented Nov 29, 2018

Hi @krazar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

1 similar comment
@ghost
Copy link

ghost commented Nov 29, 2018

Hi @krazar, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@krazar krazar closed this Nov 29, 2018
@krazar krazar deleted the variable-in-message-properties branch November 29, 2018 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant