Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump rake version #948

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bump rake version #948

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ if Dir.exist?(logstash_path) && use_logstash_source
end

if RUBY_VERSION == "1.9.3"
gem 'rake', '12.2.1'
end
gem 'rake', '12.3.3'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change cannot be made as rake 12.3.0 and above requires ruby version > 2.0, which Logstash 6.x and above requires.

We might want to think about just removing this block entirely (and in other plugins) - this is here to retain 5.x compatibility, but we haven't tested this plugin (or many others) against 5.x for some time.

Thoughts @jsvd ?

end