Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] remove pem certificate mention as it doesn't seem to be supported #947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmlrt
Copy link
Member

@jmlrt jmlrt commented Jun 18, 2020

Regarding elastic/helm-charts#587 (comment), #929 and #676, logstash-output-elasticsearch doesn't seem to accept .pem certificates despite being mentionned in the doc.

Note that a .pem certificate is also mentionned in when using ssl with client certificates. I don't know if this test is passing and if it should be removed.

`openssl req -x509 -batch -nodes -newkey rsa:2048 -keyout lumberjack.key -out #{keystore_path}.pem`

@jmlrt jmlrt requested a review from jsvd June 18, 2020 08:52
@roaksoax roaksoax requested a review from karenzone July 13, 2020 19:42
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds cleanly and LGTM, and referenced resources indicate that the change is technically accurate. @jsvd, will you please review, to be sure? Please tag me post-review and I'll handle version bump and publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants