Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove irrelevant warning #1200

Merged

Conversation

donoghuc
Copy link
Contributor

@donoghuc donoghuc commented Jan 8, 2025

This commit removes an old warning which is no longer relevant to any supported
stack version. It is noisy and there is no action for the user to take.

Closes #1198

This commit removes an old warning which is no longer relevant to any supported
stack version. It is noisy and there is no action for the user to take.
@@ -1,3 +1,6 @@
## 12.0.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also version bump logstash-output-elasticsearch.gemspec too.
Or are you going to absorb this into #1199?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of releasing both in 12.0.1 as well as backporting to 11. I'll wait to merge this until i've got a clear path. Thanks.

@donoghuc
Copy link
Contributor Author

Looks like this is addressed in https://github.com/logstash-plugins/logstash-output-elasticsearch/pull/1194/files tempted to just close this PR.

@robbavey
Copy link
Contributor

@donoghuc Let's commit this one, and have it separately, so we can choose to backport it without bringing the rest of that PR along.

Update version in preparation for a release.
@donoghuc
Copy link
Contributor Author

That makes sense. In that case, given this issue is not really moving quickly I think it makes sense just to merge this (and do a backport) and get releases out.

Copy link
Contributor

@robbavey robbavey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donoghuc donoghuc merged commit 05d5870 into logstash-plugins:main Jan 13, 2025
2 of 3 checks passed
@donoghuc
Copy link
Contributor Author

Backport PR #1202

@donoghuc
Copy link
Contributor Author

Released in 12.0.1 https://github.com/logstash-plugins/logstash-output-elasticsearch/releases/tag/v12.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary and unactionable warning given when connecting to an Elasticsearch version > 6
4 participants