Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove code related to ES 6.x and earlier #1194

Merged
merged 14 commits into from
Jan 23, 2025
Merged

remove code related to ES 6.x and earlier #1194

merged 14 commits into from
Jan 23, 2025

Conversation

jsvd
Copy link
Member

@jsvd jsvd commented Nov 28, 2024 •
edited
Loading

  • fixes secure integration tests by using credentials to check ES being up
  • remove ECS content for ES 6.x
  • remove document_type handling for 6.x
  • remove two different ways to define certain parameters like routing vs _routing
  • remove warning for ES 6.x
  • remove ES < 7 specific version handling
  • remove ES < 7 specific ILM feature checking
  • remove ES < 7 specific template handling
  • remove ES 6.x template
  • large cleanup related to ES < 7 specific tests

closes #1201

@jsvd jsvd force-pushed the drop_es6_support branch from d5015da to c85e9ae Compare December 9, 2024 13:04
@karenzone karenzone mentioned this pull request Dec 10, 2024
Merged
@jsvd jsvd marked this pull request as ready for review January 9, 2025 08:59
@jsvd jsvd changed the title remove es6 related code from lib/ remove code related to ES 6.x and earlier Jan 9, 2025
@jsvd jsvd force-pushed the drop_es6_support branch from c85e9ae to c2a558e Compare January 10, 2025 15:38
@jsvd jsvd force-pushed the drop_es6_support branch from 1e01e77 to dba2821 Compare January 15, 2025 16:21
@donoghuc donoghuc self-requested a review January 15, 2025 17:23
@jsvd
Copy link
Member Author

jsvd commented Jan 17, 2025

Tests are back to green.

donoghuc
donoghuc approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Did a bit of manual testing at debug log level and everything appears to be in order.

@jsvd jsvd merged commit ec27add into logstash-plugins:main Jan 23, 2025
3 checks passed
@jsvd jsvd deleted the drop_es6_support branch January 23, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donoghuc donoghuc donoghuc approved these changes

Assignees
No one assigned
Labels
status:work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up code related to ES < 7
2 participants
@jsvd @donoghuc