Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

output: add support for sprintf templating in message_properties #9

Merged

Conversation

yaauie
Copy link
Contributor

@yaauie yaauie commented Nov 21, 2019

Several Issues and Pull-Requests have been opened concerning the ability to set a message's priority from the content of the message; this PR solves that in such a way that all message_properties can support sprintf templates without any unnecessary per-event overhead.

  1. at plugin registration, properties are split into constant and variable subsets.
  2. per event, only the variable properties (if any) are built from the event

Resolves: #8
Duplicate of: logstash-plugins/logstash-output-rabbitmq#72
Duplicate of: logstash-plugins/logstash-output-rabbitmq#80

@andsel
Copy link

andsel commented Nov 27, 2019

Nice @yaauie I don't know if could be useful to cite this ability also in the documentation.

@theyough
Copy link

theyough commented Apr 5, 2020

Any update ? When do you plan to release it ?

@andsel
Copy link

andsel commented Apr 6, 2020

LGTM

@theyough
Copy link

theyough commented Apr 6, 2020

@yaauie Could you fix conflict, and merge it please ? thank you for your help

@yaauie yaauie force-pushed the event-powered-message-properties branch from 1030662 to c191f84 Compare May 12, 2020 22:56
@yaauie yaauie merged commit 2f75b7e into logstash-plugins:master May 13, 2020
@yaauie yaauie deleted the event-powered-message-properties branch May 13, 2020 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support sending to priority queues where priority is taken from the event
4 participants