Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS Compatiblity #57

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

yaauie
Copy link
Contributor

@yaauie yaauie commented Dec 16, 2020

This PR does several things to facilitate ease-of-use with Logstash's ECS Compatibility mode

  • introduces an optional target option, allowing users to configure where on the event a records fields should be placed. This option is validated using the Validator Support Mixin's :field_reference adapter.
  • ensures ecs_compatibility option is present via the ECS Compatibility Support Mixin, and warns when the plugin is started in an ECS Compatibility mode without specifying a target.
  • patches streaming filter to use Validator Support Mixin's :field_reference adapter when validating its pre-existing target option, causing incorrect configuration to be rejected at startup instead of plugin crashes at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants