Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(StakeManager): use custom error in onlyVault modifier #28

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

0x-r4bbit
Copy link
Collaborator

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Added natspec comments?
  • Ran forge snapshot?
  • Ran pnpm lint?
  • Ran forge test?

@0x-r4bbit 0x-r4bbit requested a review from 3esmit October 9, 2023 09:23
Base automatically changed from test/basic-tests to develop October 10, 2023 11:53
Also introduce tests that ensure the error is actually emitted.
@0x-r4bbit 0x-r4bbit merged commit eeffcfe into develop Oct 10, 2023
4 checks passed
@0x-r4bbit 0x-r4bbit deleted the refactor/onlyvault-error branch October 10, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant