-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSTORE-1328] Add list to feature store and richer repr drafts #1301
Open
vatj
wants to merge
27
commits into
logicalclocks:master
Choose a base branch
from
vatj:FSTORE-1328-clean
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
faa1add
Scaffold some structure for python SDK improved communication
vatj 182ba48
Add welcome message on connection
vatj b443792
Minor adjustments
vatj 4533b5c
Set styles like if I had a taste for these things
vatj c581a5a
Add api for get_all feature groups
vatj 62f1a1b
Add base list and table printers
vatj d7e617c
Add api call for get_all feature views
vatj 5616255
Add feature_store quicktour
vatj a7d59e6
Minor fix and clean ups
vatj 651be27
Add user_messages file
vatj 074562d
Update base tables for FGs
vatj 9845179
Add methods to feature view engine
vatj b0b616a
Add alternate table style for fg list
vatj 8e21bc1
More fixes
vatj 57ddf87
Filter by latest version for feature view api
vatj 868fbbb
Refactor + adapt feature view table
vatj 06e7298
Refactoring
vatj bca6b74
Clean up
vatj d77b784
Basic FV info draft
vatj 521695b
More table info for feature views
vatj e7184c9
More table info for feature views
vatj d912ef5
Minor adjustments
vatj 4ad9032
Remove feature_view list limitation
vatj a08a7b9
Add to quicktour to manifest
vatj fed61b4
Split description code path for show_feature
vatj d2ce151
add output to markdown quicktour
vatj 36fc1f3
Merge branch 'master' into FSTORE-1328-clean
vatj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
include ../README.md | ||
include ../LICENSE | ||
include hsfs/helpers/quicktours/feature_store.md |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may be using filter() is better for readability instead of having a for loop again