Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added attributes types and new attribute status_reasons #936

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Added attributes types and new attribute status_reasons #936

merged 4 commits into from
Dec 9, 2024

Conversation

roshanmaskey
Copy link
Collaborator

Changes

  • Added attribute definition in GCPLoggingTimesketch
  • Changed dcsa_email: str to dcsa_emails: list[str]
  • Added status_reasons: list[str]
  • Added unit test testServiceAccountCreateFailed

@roshanmaskey roshanmaskey requested a review from ramo-j December 4, 2024 08:35
@roshanmaskey roshanmaskey marked this pull request as ready for review December 4, 2024 08:35
ramo-j
ramo-j approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@ramo-j ramo-j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roshanmaskey roshanmaskey merged commit 9a0849a into log2timeline:main Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramo-j ramo-j ramo-j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roshanmaskey @ramo-j