Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: launch gpg-forwarding during UP if flag is specified #803

Merged

Conversation

89luca89
Copy link
Contributor

This fixes a behavioural bug,
if we specify the --gpg-agent-forwarding during up, we expect it to take immediate effect when using our IDE

This fixes the inconsistency

Resolves ENG-1900

@FabianKramm
Copy link
Member

@89luca89 thanks for the PR! I'm not sure why this is needed, isn't gpg forwarding only useful during ssh forwarding?

@89luca89
Copy link
Contributor Author

@89luca89 thanks for the PR! I'm not sure why this is needed, isn't gpg forwarding only useful during ssh forwarding?

More like a behaviour uniformity
When I say up --gpg-agent-forwarding I expect to have gpg agent forwarding immediately, not at the next ssh command
Now this is not a problem with IDEs based on ssh (vscode, jetbrains) but for other non-ssh based IDEs, this won't be the case

For example with fleet or with openvscode (web)

Same goes for forwarded ssh agent and so on, this ensures the behaviour is the same on all IDEs

@FabianKramm
Copy link
Member

@89luca89 can we move this logic then only to those ides? Also why is that required for fleet?

@89luca89
Copy link
Contributor Author

@89luca89 can we move this logic then only to those ides? Also why is that required for fleet?

Done

Copy link
Member

@pascalbreuninger pascalbreuninger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pascalbreuninger pascalbreuninger merged commit 6c384e5 into loft-sh:main Nov 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants