Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssh): add support for interactive ssh keys when adding to SSH agent #1548

Closed
wants to merge 1 commit into from

Conversation

pascalbreuninger
Copy link
Member

@pascalbreuninger pascalbreuninger commented Jan 13, 2025

Separates between SSH keys that can be used as-in and the ones that
require additional input from the user like a passphrase.
In the latter case we now check if Stdin is interactive and prompt users
for input if it is.

solves #1546

Copy link
Contributor

@bkneis bkneis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one nit and a question on timeout length

@pascalbreuninger
Copy link
Member Author

FYI: Waiting for the creator of ticket #1546 to try this PR before merging into main

@MartinLoeper
Copy link

Thanks so much for picking this up so quickly @pascalbreuninger.
I checked out your branch, built it and tested it. It just works! :)

There was another issue I had to fix though and I want to hear your opinion on it:
I had to run eval $(ssh-agent) before running devpod.
The reason being gpg-agent is apparently in read-only mode under certain circumstances.
This is an issue as devpod tries to add a bunch of ssh keys to it leading to errors like could not add identity: agent refused operation. Is there a way to make devpod users aware of it and that they should fix their ssh-agent configuration to make it writable?

Separates between SSH keys that can be used as-in and the ones that
require additional input from the user like a passphrase.
In the latter case we now check if Stdin is interactive and prompt users
for input if it is.
@pascalbreuninger
Copy link
Member Author

Closing this in favor of #1559 because I've accidentally pushed from my main branch and this is really annoying to develop against :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants