Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Microsoft.ServiceFabric.Actors from 7.1.2338 to 7.1.2448 #206

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 24, 2024

Bumps Microsoft.ServiceFabric.Actors from 7.1.2338 to 7.1.2448.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps Microsoft.ServiceFabric.Actors from 7.1.2338 to 7.1.2448.

---
updated-dependencies:
- dependency-name: Microsoft.ServiceFabric.Actors
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 24, 2024
@abatishchev
Copy link
Collaborator

/azp run

Copy link

No pipelines are associated with this pull request.

@abatishchev
Copy link
Collaborator

@loekd, I see one of the tests fails:

Failed DataPackageAtMockCodePackageActivationContextTest [1 s]
  Error Message:
   Test method ***.NetCoreTests.ServiceTests.ConfigurationPackageTests.DataPackageAtMockCodePackageActivationContextTest threw exception: 
System.MissingMethodException: Constructor on type 'System.Fabric.DataPackage' not found.
  Stack Trace:
      at System.RuntimeType.CreateInstanceImpl(BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture)
   at System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture, Object[] activationAttributes)
   at System.Activator.CreateInstance(Type type, BindingFlags bindingAttr, Binder binder, Object[] args, CultureInfo culture)
   at ***.ReflectionHelpers.CreateInstance[T]() in D:\a\***\***\src\***\ReflectionHelpers.cs:line 17
   at ***.MockDataPackage.CreateDataPackage(String path, DataPackageDescription description) in D:\a\***\***\src\***\MockDataPackage.cs:line [27](https://github.com/loekd/ServiceFabric.Mocks/actions/runs/11021392653/job/30608356124?pr=206#step:8:28)
   at ***.NetCoreTests.ServiceTests.ConfigurationPackageTests.DataPackageAtMockCodePackageActivationContextTest() in D:\a\***\***\test\***.NetCoreTests\ServiceTests\ConfigurationPackageTests.cs:line 24

Does it mean the SF team made a change internally which we need to address (fore we can update to the latest SF runtime)? How often this happens?

@loekd
Copy link
Owner

loekd commented Sep 30, 2024

@abatishchev Sometimes the team makes breaking changes. This time there seem to be quite a few. Including one I can't seem to fix myself.
This call makes a call to a static class FabricEnvironment:
image
Which has this code:
image

which crashes with a null reference exception:

at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_1(Object state)
   at System.Threading.QueueUserWorkItemCallback.Execute()
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at System.Fabric.Interop.NativeTypes.FromNativeString(IFabricStringResult result)
   at System.Fabric.Interop.StringResult.FromNative(IFabricStringResult nativeResult)
   at System.Fabric.Common.FabricEnvironment.GetCodePathHelper(String machineName)
   at System.Fabric.Common.FabricEnvironment.<>c__DisplayClass6_0.<GetCodePath>b__0()
   at System.Fabric.Interop.Utility.WrapNativeSyncInvoke[TResult](Func`1 func, String functionTag, String functionArgs)
   at System.Fabric.Common.FabricEnvironment.GetCodePath(String machineName)
   at System.Fabric.Common.FabricEnvironment.GetCodePath()
   at Microsoft.ServiceFabric.Data.ReliableStateManager..ctor(StatefulServiceContext serviceContext, ReliableStateManagerConfiguration configuration)

@loekd
Copy link
Owner

loekd commented Oct 1, 2024

I've created an issue on the SF repo.
Really don't see a way to work around this on our end.

@abatishchev
Copy link
Collaborator

I'll try to draw attention to this issue internally

@abatishchev
Copy link
Collaborator

abatishchev commented Oct 1, 2024

@loekd do you know if the CI pipeline installs both the latest NuGet package and the SF runtime every time?

@abatishchev
Copy link
Collaborator

I see it uses a static (hard-coded) version:

Invoke-RestMethod -OutFile setup.exe -Method GET -Uri https://download.microsoft.com/download/b/8/a/b8a2fb98-0ec1-41e5-be98-9d8b5abf7856/MicrosoftServiceFabric.10.1.1951.9590.exe

Let me try to update it to the latest, per https://learn.microsoft.com/en-us/azure/service-fabric/service-fabric-get-started#download-and-install-the-runtime-and-sdk

@abatishchev
Copy link
Collaborator

@loekd I see it worked. yay! can you please double check?

@loekd loekd merged commit 69aedeb into master Oct 2, 2024
4 checks passed
@loekd loekd deleted the dependabot/nuget/Microsoft.ServiceFabric.Actors-7.1.2448 branch October 2, 2024 08:20
@loekd
Copy link
Owner

loekd commented Oct 2, 2024

I have issues with the devcontainer/codespace, but I'll trust the build pipelines here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants