-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Generate unique and descriptive filenames for download #3021
Conversation
d7d8b67
to
e627588
Compare
website/src/components/SearchPage/DownloadDialog/DownloadUrlGenerator.ts
Outdated
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/DownloadDialog.spec.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I already thought that we might iterate on the exact filename, but I was happy with getting all the components in place. I agree on the casing stuff and the filename being to long, I like all your suggestions! |
e627588
to
a22b063
Compare
website/src/components/SearchPage/DownloadDialog/DownloadUrlGenerator.ts
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/DownloadUrlGenerator.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just realized we don't indicate segments/genes in sequence file names. Might be nice to add that after the respective seq type:
nuc-L
or aa-aligned-2K
This only applies to segmented nucs and AAs (if it's main
then leave it out)
dd9cd7c
to
89f3a63
Compare
…ype.ts Co-authored-by: Cornelius Roemer <[email protected]>
6017fa9
to
c53a0ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, just some small non-blocking suggested! We can iterate on the rest as we go, nothing blocking!
website/src/components/SearchPage/DownloadDialog/DownloadDialog.spec.tsx
Show resolved
Hide resolved
website/src/components/SearchPage/DownloadDialog/DownloadDialog.spec.tsx
Show resolved
Hide resolved
Thanks for the review! I didn't make these test changes as I prefer to keep unit tests with rather less than more levels of indirection and templating. |
Co-authored-by: Cornelius Roemer <[email protected]>
resolves #2327
resolves #2689
preview URL: https://feat-2327-better-download.loculus.org
Summary
Generates filenames like
cchf_nuc_2024-10-23T1225.fasta
for the files that are downloaded from the DownloadDialog.PR Checklist