Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(config): Add version_comment field to be used when revising sequences. #2355

Merged
merged 4 commits into from
Jul 30, 2024
Merged

feat(config): Add version_comment field to be used when revising sequences. #2355

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e8dd8f
Add version comments
anna-parker Jul 30, 2024
8148ac4
fix sequence details page
anna-parker Jul 30, 2024
1fa674c
Just use as simple metadata field as otherwise not showing up on deta…
anna-parker Jul 30, 2024
a0945a5
Change version_comments to version_comment
anna-parker Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions kubernetes/loculus/templates/_common-metadata.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ fields:
type: int
notSearchable: true
hideOnSequenceDetailsPage: true
- name: version_comments
type: string
notSearchable: true
header: Submission details
- name: submissionId
type: string
header: Submission details
Expand Down
10 changes: 3 additions & 7 deletions kubernetes/loculus/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,6 +1009,9 @@ defaultOrganismConfig: &defaultOrganismConfig
rangeSearch: true
preprocessing:
inputs: {input: nextclade.coverage}
- name: version_comments
anna-parker marked this conversation as resolved.
Show resolved Hide resolved
displayName: Version Comments
header: Submission details
website: &website
tableColumns:
- sample_collection_date
Expand All @@ -1030,13 +1033,6 @@ defaultOrganismConfig: &defaultOrganismConfig
example: GJP123
position: first
noEdit: true
- name: version_comments
displayName: Version Comments
definition: Additional comments about version
guidance: Used when revising sequences
example: Previous version filled Ns with the reference sequence.
header: Submission details
position: first
preprocessing:
- &preprocessing
version: 1
Expand Down
Loading