wip: Dontshowgenes2 #1912
Closed
wip: Dontshowgenes2 #1912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct - this allows the mutations to be searchable with an appended gene name (and will be visible when the amino acid mutations are copied) but it will not be shown on the page.
- Refactor revise test to not require an explicit file but set file from buffer. (Async file setting was also incorrectly not awaited for) - Disable buttons when React stuff is server side rendered. Playwright would otherwise click buttons in HTML without the react event handlers attached which made tests flaky: in particular locally where things are faster than in CI - Uses data-testid for elements/buttons that are hard to get from Playwright otherwise - Get rid of unnecessarily tight timeout (1s) in seqset test (default is 5s) - Add npm run script e2e:ui that opens playwright GUI mode with headed playwright: this makes it particularly easy to debug tests and see why they fail (extensively used in the preparation of this) (cherry picked from commit c29b912)
Dependabot bug: dependabot/dependabot-core#9690 (cherry picked from commit dd6f93b)
(cherry picked from commit 9af75fd)
* chore(ci): use node version from `.nvmrc` (cherry picked from commit c51d6d3e00e94170d71c9c9b73a31d219e2955e2) * chore(website): bump node from v21 to v22 See release notes https://nodejs.org/en/blog/announcements/v22-release-announce (cherry picked from commit 3a1ea87)
…t limits (#1845) -Don't retry when NCBI ingest fails, as this causes rate limits to trip -Use NCBI API Key. In cleartext for now (while we're private that's no problem). It's easy to generate these keys and easy to reset so there's no risk to using it like this right now. For proper encryption see Set NCBI API key through secret #1844 (cherry picked from commit 1dbfcba)
(cherry picked from commit ac470d4)
* add compression middleware * update * fix (cherry picked from commit b64b535)
Setting resource limits is good for 2 reasons: - Java containers set the heap size based off how much memory they have available. No limits mean they think they've got the whole machine. Setting limits fixes this effectively. Backend memory usage goes down from 3GB to 500MB. Finally things get garbage collected. - Step towards limiting swapping which currently can happen. We want to prioritize central services and non-kubernetes resources over preview deployments. I set memory requests and limits for all, but only cpu requests, as cpu limits are not very useful (we are not CPU limited usually and throttling works well usually). (cherry picked from commit ead6afc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #
preview URL:
Summary
Screenshot
PR Checklist