Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean columns #1715

Merged
merged 3 commits into from
May 2, 2024
Merged

Boolean columns #1715

merged 3 commits into from
May 2, 2024

Conversation

fengelniederhammer
Copy link
Contributor

@fengelniederhammer fengelniederhammer commented Apr 30, 2024

resolves #1713

preview URL: https://booleancolumn.loculus.org/

Summary

See ticket - SILO now supports metadata type boolean.

This also includes some small refactoring (moving logic out of the Astro frontmatter and using neverthrow results more idiomatically).

Screenshot

UI-wise, nothing should change. But LAPIS now returns boolean values:

{
  "data": [
    {
      "count": 1,
      "isRevocation": true
    },
    {
      "count": 60,
      "isRevocation": false
    }
  ],
  "info": {
    "dataVersion": "1714465022",
    "requestId": "8a28d34f-885b-4a5e-a5f1-238b53da58a2",
    "requestInfo": "Test Dummy Organism on localhost at 2024-04-30T08:19:48.766097331",
    "reportTo": "Please report to https://github.com/GenSpectrum/LAPIS/issues in case you encounter any unexpected issues. Please include the request ID and the requestInfo in your report."
  }
}

PR Checklist

  • [ ] All necessary documentation has been adapted.
  • The implemented feature is covered by an appropriate test.

@fengelniederhammer fengelniederhammer added the preview Triggers a deployment to argocd label Apr 30, 2024
and make `isRevocation` a boolean

resolves #1713
Copy link
Member

@chaoran-chen chaoran-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

When merging, please make sure to rebase instead of squash so that the refactoring does not get merged together with the actual boolean column implementation.

@fengelniederhammer fengelniederhammer merged commit b1812c1 into main May 2, 2024
13 checks passed
@fengelniederhammer fengelniederhammer deleted the booleanColumn branch May 2, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Boolean columns
2 participants