Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cI): allow PR autoformatting with a label #1712

Merged
merged 10 commits into from
Apr 30, 2024
Merged

Conversation

theosanderson
Copy link
Member

@theosanderson theosanderson commented Apr 29, 2024

Expands our autoformatting workflow (previously just a workflow dispatch) so you can add the format_me label to a PR to have it autoformatted. Later we can get the formatting commits to use a PAT, and then they will trigger CI, which they don't atm.

@theosanderson theosanderson added the format_me Triggers github_actions to format website code on PR label Apr 29, 2024
@theosanderson theosanderson changed the title try to expand autoformatting with a PR label chore(cI): allow PR autoformatting with a label Apr 29, 2024
Copy link
Contributor

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this opt-in, don't see downsides right now other than even more commits on your branches 😆 Maybe just remember to clear the lengthy auto-generated commit messages when squash-merging your PRs.

@theosanderson
Copy link
Member Author

Do we use commit bodies for anything atm?

@corneliusroemer
Copy link
Contributor

Do we use commit bodies for anything atm?

They show in things like git log by default which I use regularly. That's where I see your *format *tweak's :)

image

@theosanderson
Copy link
Member Author

OK, maybe I need to make an action to do merges for me to avoid that for you!

@theosanderson theosanderson merged commit e15bac9 into main Apr 30, 2024
@theosanderson theosanderson deleted the expand-autoformat branch April 30, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_me Triggers github_actions to format website code on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants